Docs: credential-gate override logging is best-effort, not guaranteed (fixes #119) - #222
Merged
Merged
Conversation
…#119) Docs-only correctness fix in both README mirrors. The credential-gate section claimed the approved override's every use is logged; the hook's own _log() swallows every exception (except Exception: pass) and the README's shared auditability paragraph already says hook log writes are best-effort. Both mirrors now state the actual contract in parity: every approved override ATTEMPTS to append an audit event, the write is best-effort, a failed write is silently dropped, and a logging failure never blocks the hook. Runtime/code unchanged; code stays authoritative. Fixes #119 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0132RthrKSsMkywcEwtkXhkx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #119. Docs only — code/runtime unchanged; the code stays authoritative.
The credential-gate section of both README mirrors overstated the override's audit contract: "every use is logged" reads as a guarantee, while the hook's own
_log()swallows every exception (except Exception: pass) and the README's shared auditability paragraph already describes hook log writes as best-effort. This PR softens the overstatement to the actual contract, in English/zh-Hant parity, preserving all four facts:README.mdREADME.zh-Hant.mdVerification
hooks/gate-credential-destruction.pyblob byte-identical to main; the_log()exception swallow re-confirmed first-hand at the current head.checks.pygreen (including the README projection-parity gate and the invisible-Unicode sweep).🤖 Generated with Claude Code
https://claude.ai/code/session_0132RthrKSsMkywcEwtkXhkx