Skip to content

Added page, fixed tests. #2839 - #2842

Merged
knirirr merged 13 commits into
devfrom
documentation_page_2839
Jul 28, 2026
Merged

Added page, fixed tests. #2839#2842
knirirr merged 13 commits into
devfrom
documentation_page_2839

Conversation

@knirirr

@knirirr knirirr commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This adds a documentation page. As requested in #2839 it's not linked from anywhere; the URL /documentation will have to be added into the address bar manually.

In addition, various test issues have been tidied up.

Please feel free to edit text directly in views/static/Documentation/Documentation.vue or make suggestions via the Github interface.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Coverage Report for Vitest Coverage

Status Category Percentage Covered / Total
🟢 Lines 97.14% (🎯 90%) 2452 / 2524
🟢 Statements 97.15% (🎯 90%) 2492 / 2565
🟢 Functions 95.45% (🎯 90%) 630 / 660
🟢 Branches 95.59% (🎯 90%) 760 / 795
File CoverageNo changed files found.
Generated in workflow #7485 for commit c1932f3 by the Vitest Coverage Report Action

@knirirr
knirirr requested a review from allysonlister July 23, 2026 08:53

@allysonlister allysonlister left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope i've done it correctly but I think that perhaps you'll need to check my rusty html thanks!

Comment thread src/views/Static/Documentation/Documentation.vue Outdated
Comment thread src/views/Static/Documentation/Documentation.vue Outdated
Comment thread src/views/Static/Documentation/Documentation.vue Outdated
Comment thread src/views/Static/Documentation/Documentation.vue
Comment thread src/views/Static/Documentation/Documentation.vue Outdated
Comment thread src/views/Static/Documentation/Documentation.vue
Comment thread src/views/Static/Documentation/Documentation.vue
Co-authored-by: Allyson Lister <allyson.lister@oerc.ox.ac.uk>
@knirirr
knirirr requested a review from allysonlister July 23, 2026 12:03

@allysonlister allysonlister left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there are various stylistic ways to do this, so I am not creating inline changes as I don't know which ones you prefer.

Please could all of the phrases before the ":" be bolded, and please could all of the URLs be hyperlinked.

@knirirr

knirirr commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

I have no preference.

@allysonlister

Copy link
Copy Markdown
Contributor

cool - please can you make the updates then?

@knirirr
knirirr requested a review from allysonlister July 23, 2026 15:21

@allysonlister allysonlister left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks super thank you!

@knirirr
knirirr merged commit 2681e1c into dev Jul 28, 2026
16 checks passed
@knirirr
knirirr deleted the documentation_page_2839 branch July 28, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants