Implement Multi-Day Event attendance via per-day Check-in Posts - #49
Merged
Conversation
A Multi-Day Event now generates one synthetic Multi-Day Child Event per calendar day of its span (ordinary all_day Events), reusing the existing Check-in Post / Reaction Cutoff / Event Attendance Report machinery unmodified. Every Child's Check-in Post is front-loaded to a shared time (checkin_offset_multiday_days, default 2 days before the span's first day), while each Child's own Reaction Cutoff still lands independently at the end of its own day. The Multi-Day Event parent row is untouched — it keeps driving the Weekly Summary Post exactly as before. Child identity is keyed by calendar date (not by offset from the current span's start), so a span shift reconciles only the days that actually entered or left the span rather than reassigning every day's already- collected attendance. Reconciliation never touches an already-finalized Child, and a Multi-Day Event edited down to a non-multi-day span cleans up its previously-generated Children. Multi-Day Children are excluded from the No Response Alert's streak query (one missed competition isn't three missed meetings) but still count normally toward Season hours/attendance %. Closes #32. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #32. A Multi-Day Event now gets real Attendance Tracking by generating one synthetic Multi-Day Child Event per calendar day of its span (ordinary
all_dayEvents), reusing the existing Check-in Post / Reaction Cutoff / Event Attendance Report machinery unmodified:checkin_offset_multiday_days, default 2 days before the span's first day) — one batch of posts, not staggered — while each Child's own Reaction Cutoff still lands independently at the end of its own dayWent through
/code-review(8 finder angles + independent verification) before this PR — 8 confirmed issues (finalized-Child protection, orphaned Children on a meeting-type edit, positional vs. date-keyed identity, a DST-unsafe date computation, spurious edit-broadcast noise, a triplicated code pattern, and a stale doc citation) were all fixed and re-verified.Companion to the docs branch
docs/multiday-event-attendance(#48) — domain docs and code are kept on separate branches/PRs per this repo's convention.Test plan
npm run typechecknpm test(198/198 passing, including new coverage for child generation, span-shift reconciliation, and the day-suffix title-diffing fix)npm run format:checknpm run build