Link check-in and summary titles to their calendar events; add subscribe links - #54
Merged
Conversation
…ar-subscribe links Check-in Post title (original, edited, locked, removed variants) links to the Event's own calendar_link when present. Weekly Summary, Informational Reply, and Mentor/Teacher Summary lines link each title to its Event, and each digest gets a footer link to subscribe to its underlying Google Calendar. calendarLink threads through WeeklySummaryEventInfo; a removed item's link comes from the still-present Event row (calendar_link doesn't change across edits), not a schema migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calendar_linkis present.eventsrow (a calendar event's own link doesn't change across edits), not a new snapshot column.Builds on #53 (already merged) — this PR's diff is just the new linking work.
Test plan
npm run typechecknpm test(211 passing, including new coverage for title-linking andcalendarSubscribeLink)npm run format:checknpm run build/code-review; one finding (a repeated null-check ternary across 3 call sites) fixed by folding the guard intocalendarSubscribeLinkitself.lockedCheckinMessageText/formatWeeklySummaryLine/assembleWeeklySummaryMessageto confirm the rendering looks right.