Add CTS-controlled pending application - #3
Draft
ap0calypse644 wants to merge 8 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ControlledConfidentialTransferClient, preserving automaticapplyPendingby default but allowing orchestrators to disable it withautoApplyPending: falseapplyPending()method without changing the existingConfidentialTransferClientAPIResultCodeasuint8, current field ordering, current offchain flag placement)applyPending()forwardingWhy
CTS must own pending-state scheduling explicitly. Hidden auto-apply inside deposit/transfer/withdraw would make
applyPendingtraffic impossible to schedule, persist, quarantine, and reconcile independently.The existing SDK behavior remains backwards compatible because auto-apply stays enabled unless a caller explicitly disables it.