Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: chunk-level extraction cache for update() (cache_unchanged_chunks) #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat: chunk-level extraction cache for update() (cache_unchanged_chunks) #288
Changes from all commits
cb248855cfd34edc295601395945a90d1ac7cd0c8507eae99d6ddcf4ba00308d8e46b8160fd8f9c251fb42a978419c9aeb582a2d4f6ca63eddd111136677777b1088f60f04af6d9ca888b057b7File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth stepping back on this comparison generally.
Inside the SDK both sides are already symmetric —
_write_graph_configwritesself.embedder.model_nameand this reads it back to compare againstself.embedder.model_name. A graph written by this SDK and read by this SDK cannot hit the prefix mismatch. The asymmetry is entirely the server'sEmbedderConfig.to_embedder()storing a bare name and later constructing a prefixed one.So a global invariant is being loosened for every SDK user to compensate for a caller bug in a different repo. And because
_write_graph_configusesMERGE ... SET, affected graphs rewrite the stored name on their next successful ingest — only the bootstrap needs a one-shot fix.The original incident (a
ConfigErrorthat then broke every subsequent update) is a legitimate complaint, but it's a complaint about an un-overridable, inscrutable error, not about the error existing. That's fixable without widening the check:The third branch is where this PR's users land, and the message carries its own fix: "same base model via a different provider — pass
embedding_model_policy='allow_provider_change'if these vectors are comparable." One deliberate line during a rare, supervised migration, and it self-heals on the next write. That's a much better shape than permanently relaxing the check for everyone.Preference order: fix
EmbedderConfigupstream > probe-vector fingerprint > explicit override flag > the current string widening.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.