Skip to content

Several tweaks for brainsweep sacrifice entity display#1023

Merged
Robotgiggle merged 4 commits intoFallingColors:mainfrom
YukkuriC:feature/brainsweepee-display
May 9, 2026
Merged

Several tweaks for brainsweep sacrifice entity display#1023
Robotgiggle merged 4 commits intoFallingColors:mainfrom
YukkuriC:feature/brainsweepee-display

Conversation

@YukkuriC
Copy link
Copy Markdown
Contributor

@YukkuriC YukkuriC commented Apr 2, 2026

  • loop display every choices for tag ingredient
  • cache them on client to prevent by-frame new instances

Copy link
Copy Markdown
Member

@Robotgiggle Robotgiggle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cycling entity display only works in recipe viewers, not in the guidebook. Making it work in the guidebook is totally possible though, you'd just need to change some things around in the component processor for brainsweep recipes. That should probably get done before this gets merged.

@github-project-automation github-project-automation Bot moved this from 📋 Backlog to 🏗 In progress in Hex Casting May 8, 2026
@s5bug
Copy link
Copy Markdown
Contributor

s5bug commented May 9, 2026

@YukkuriC If you haven't started working on this change, don't worry about it, I'll implement it. If you have, let me know so we don't duplicate work!

…dering

Co-Authored-By: Aly Cerruti <7751296+s5bug@users.noreply.github.com>
@Robotgiggle Robotgiggle force-pushed the feature/brainsweepee-display branch from ce7788d to 028a19b Compare May 9, 2026 07:10
Copy link
Copy Markdown
Member

@Robotgiggle Robotgiggle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out Patchouli is in fact not capable of showing cycling entity displays, so we won't be able to implement that yet in this PR.

However, some preliminary refactoring to turn exampleEntity into exampleEntities for ease of use has been done anyway, and an issue has been created in the Patchouli repo (VazkiiMods/Patchouli#852) to hopefully enable cycling entities at some point in the future.

@Robotgiggle Robotgiggle added this pull request to the merge queue May 9, 2026
Merged via the queue into FallingColors:main with commit 4e61b42 May 9, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from 🏗 In progress to ✅ Done in Hex Casting May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants