Add pre-commit formatting#771
Draft
vgskye wants to merge 2 commits intoFallingColors:mainfrom
Draft
Conversation
Member
|
maybe we should also add a pre-commit config? could also include ruff (Python formatting) for the hexdoc code |
vgskye
force-pushed
the
format-hell
branch
2 times, most recently
from
369d689 to
f782490
Compare
vgskye
force-pushed
the
format-hell
branch
2 times, most recently
from
057a4c5 to
bb0a85d
Compare
added 2 commits
November 26, 2024 20:00
object-Object
force-pushed
the
main
branch
4 times, most recently
from
107cf95 to
7202ed7
Compare
s5bug
suggested changes
May 9, 2026
Contributor
s5bug
left a comment
s5bug
left a comment
There was a problem hiding this comment.
Would be nice if there was an addition to the PR/CI action that caused failures if code was not formatted. I'm someone who 1. forgets to install pre-commit hooks 2. doesn't like pre-commit hooks and would rather run formatting manually anyway. I'm sure (1) will be very common for other people too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.