Skip to content

fix(packages-fetch): add Send bound to download_file_with_progress callbacks #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackees merged 2 commits into from
Aug 10, 2026
Merged

fix(packages-fetch): add Send bound to download_file_with_progress callbacks #1295

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f99734
fix(packages-fetch): add Send bound to download_file_with_progress ca…
zackees Aug 10, 2026
6a445f4
chore: trigger CI for Dylint
zackees Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/fbuild-packages-fetch/src/downloader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ async fn get_with_retry_using(client: &reqwest::Client, url: &str) -> Result<Vec
pub async fn download_file_with_progress(
url: &str,
dest_dir: &Path,
on_progress: &mut dyn FnMut(&DownloadProgress),
on_progress: &mut (dyn FnMut(&DownloadProgress) + Send),
) -> Result<PathBuf> {
download_file_with_progress_using(http::client(), url, dest_dir, on_progress).await?;
let filename = url.rsplit('/').next().unwrap_or("download");
Expand All @@ -271,7 +271,7 @@ async fn download_file_with_progress_using(
client: &reqwest::Client,
url: &str,
dest_dir: &Path,
on_progress: &mut dyn FnMut(&DownloadProgress),
on_progress: &mut (dyn FnMut(&DownloadProgress) + Send),
) -> Result<()> {
download_file_with_progress_timed(client, url, dest_dir, on_progress, RetryTiming::PRODUCTION)
.await
Expand All @@ -283,7 +283,7 @@ async fn download_file_with_progress_timed(
client: &reqwest::Client,
url: &str,
dest_dir: &Path,
on_progress: &mut dyn FnMut(&DownloadProgress),
on_progress: &mut (dyn FnMut(&DownloadProgress) + Send),
timing: RetryTiming,
) -> Result<()> {
let filename = url.rsplit('/').next().unwrap_or("download").to_string();
Expand Down
Loading