fix(workflows): default all reusable runners to ubuntu-latest for public consumers#45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #44 added
runner: ubuntu-latestdefaults for the main job in each reusable workflow but left auxiliary jobs hardcoded toferrlabs-k8s. Public-repo consumers (FerrFlow, FerrGames-Cloud, etc.) hit those auxiliary jobs and they queue indefinitely waiting for a self-hosted runner that doesn't exist.Symptom from FerrFlow's
Secrets + CVE / gitleaks (secrets)check:Fix
All
runs-on: ferrlabs-k8sswapped toruns-on: ${{ inputs.runner }}across:reusable-security-scan.yml— addedrunnerinput (was missing entirely), all 3 jobs (gitleaks, osv-scanner, trufflehog)reusable-ci-astro.yml— i18n + lighthouse jobsreusable-ci-node.yml— quality jobreusable-docker-build.yml— hadolint, trivy, cosign, sbom jobsreusable-release-rust.yml— addedrunnerinput (was missing), upload + publish-crate + publish-docker jobsDefault in every case:
'ubuntu-latest'. Private consumers can still passrunner: 'ferrlabs-k8s'to opt back into the self-hosted pool.renovate.ymlkeepsferrlabs-k8sbecause it's the org's own internal workflow, not a reusable consumed by public repos.Test plan
ferrlabs-k8sleft asruns-on:in reusable workflows (only as a default override mention in input descriptions)ubuntu-latestinstead of queuing foreverrunnerinput