Skip to content

Add sourceConceptId uniqueness validation + bump to v2.1.3#72

Merged
javier-gracia-tabuenca-tuni merged 2 commits intodevelopmentfrom
copilot/sub-pr-71
Mar 23, 2026
Merged

Add sourceConceptId uniqueness validation + bump to v2.1.3#72
javier-gracia-tabuenca-tuni merged 2 commits intodevelopmentfrom
copilot/sub-pr-71

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 23, 2026

Adds a new validation rule to validateUsagiFile ensuring sourceConceptId values are unique across the Usagi file.

Changes

  • Validation: New rule checks that sourceConceptId is unique; duplicate IDs now surface as validation errors
  • Tests: Updated test fixtures to use valid, non-conflicting concept codes; refactored uniqueness check to operate on a deduplicated tibble using validate::
  • Version: Bumped to 2.1.3; NEWS.md updated with change entry

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: javier-gracia-tabuenca-tuni <54809193+javier-gracia-tabuenca-tuni@users.noreply.github.com>
Agent-Logs-Url: https://github.com/FinOMOP/ROMOPMappingTools/sessions/555fe035-a196-48bd-8575-135d887f5a1b
Copilot AI changed the title [WIP] Update version to patch in DESCRIPTION and NEWS.md Add sourceConceptId uniqueness validation + bump to v2.1.3 Mar 23, 2026
@javier-gracia-tabuenca-tuni javier-gracia-tabuenca-tuni marked this pull request as ready for review March 23, 2026 09:25
@javier-gracia-tabuenca-tuni javier-gracia-tabuenca-tuni merged commit f4f3af4 into development Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants