Reduce the codebase: comments, duplication, and single-use indirection

[FireSquid6]

A pure reduction pass over every workspace. No feature work, no bug fixes.

What changed

Commit	Change	Net
c1fae78	Tighten the comment policy to default-no-comment	+18
4abd276	Strip comments the policy no longer allows	−1,394
5bc3c0a	Consolidate duplication, drop single-use indirection	−69
f6b43e6	Extract the twin packages' shared cores	+321
86cecc6	Map route errors once per plugin	−217
3106995	Delete Store methods with no callers	−12

Net −1,353 lines. Existing source shrank by ~1,900; the two new shared
packages add ~560 back, so the headline number understates the reduction.

751 tests pass, 0 fail, typecheck clean — verified after every step.
Baseline was 746: seven tests moved into fleet-cli-kit, five are new and
pin cli-bun's shared command base.

Reviewing this

4abd276 is comment-only. Filtering git diff -U0 to non-comment,
non-blank lines yields four items: three trailing-comment strips and one
catch { /* ignore */ } collapsing to catch {}. It can be read at a glance
or trusted wholesale; the later commits are where the substance is.

Eight ghost comments went with it — text describing code that no longer
exists, including a restoreAlt that is called leaveAlt, a header claiming
websockets were out of scope with attach 170 lines below, a doc calling the
already-shipped Eden client hypothetical, and a documented BRIDGE_URL env
var nothing reads.

Worth a closer look

86cecc6 removed 39 of 40 inlined mapError catches. Two keep their
inline catch deliberately: ship's GET /armory needs mapArmoryError, and
the terminal proxy's upstream.onmessage site closes sockets in the reverse
order of its siblings. The hook guards on instanceof against Elysia's own
error types — Elysia derives its error code from error.code, so an
unguarded hook renders validation failures as 500.

Differential probes over every route by error class confirm status,
content-type and body are byte-identical: 647/647 on the bridge, and on the
ship every reachable case.

f6b43e6 keeps ShellBackend separate per package. Sharing it would
have added an env parameter to tmux's public constructor, which never had
one.

Two things this pass found but did not fix

• fagent/src/agent-ship.ts parses JSON outside its try and before the
  !response.ok check, so a 500 with a non-JSON body throws SyntaxError
  instead of the intended message.
• Session.exists() and Tmux.hasSession() call tryRun, which never
  throws, so an unreachable tmux server reports "session does not exist".

Also noted: Eden Treaty's .data/.error resolve to any in this repo,
before and after this change. The route paths are typed; the payloads are
not.

🤖 Generated with Claude Code