Add the route next up is read from, superseding 0010 - #274
Merged
Conversation
0010 is the authority for which paths the core may reach and it has no row for next up. The kickoff names next up on the first screen a television shows, so the shelf gets built either way; without a row it is built from a path in no enumeration, and #70's test then judges a smaller surface than the client uses. 0039 already met the absence and had to refuse half of #39's scope over it. 0272 carries 0010's table with one row added - next-up, GET /Shows/NextUp, assertion - and the argument the row is for: the route exists on both supported lines and answers with the item type and the page 0039 already fixes, a 404 on it is capability-absent because the path carries no caller-supplied identifier, and its enableResumable default asks for a set that overlaps the resume list, which is a cost of the route stated here and a parameter left to #39. The whole table is carried because whole-record supersession is the only shape 0001 offers; #267 is where a partial one is asked for and this does not invent it. The readings behind the sixteen carried rows were not retaken, which the record says of itself. 0010 keeps its text and gains Superseded by 0272, which is the edit 0001 permits when a replacing record lands. Signed-off-by: Nils Lehnen <30603423+iderex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue this belongs to
Closes #272
What changed
docs/decisions/0272-the-route-next-up-is-read-from.mdis added and supersedes0010. It carries 0010's table with one row added -
next-up, read fromGET /Shows/NextUp- and the argument for that row: what a first screen loseswithout it, what the route costs against both supported lines, and what an absence
of it means for a client that has already reserved the shelf.
0010's
Statusline gainsSuperseded by 0272, which is the edit 0001 permitswhen a replacing record lands, and
docs/decisions/README.mdgains the index line.Nothing else in 0010 changes.
This is the first supersession in this tree, so the spelling comes from 0001 rather
than from a neighbour. Read at the merge base:
What failure it prevents
0010 is the authority for which paths the core may reach and it has no row for next
up. The kickoff names next up on the first screen a television shows, so the shelf
is going to be built; without a row it is built from a path that is in no
enumeration. #70's test - which fails when the core reaches a host nobody
configured - then judges a smaller surface than the client actually uses, and the
core's own list of what it depends on is wrong by one.
This has already happened once in the cheap form. #39 asked for resume and next up
together, found the resume row in the table and no next-up row, and 0039 had to
refuse half its own scope and say so:
The expensive form is the same absence met at a call site instead, where the
cheapest way out is to write the path and move on.
Evidence
Every reading in the record was taken against the two commits 0010 names, through
the server's own repository over the network rather than through a clone. The two
lines first, so the rest is anchored:
The route exists on both and answers with the type 0039 already fixes:
The cost the record spends most of its argument on, which is a default rather than
a server behaviour:
The remaining blocks - the paging parameters, the base route and the authorization,
and the one parameter the two lines disagree about - are in the record with the
command that produced each.
Every link the record names resolves:
The check that reads those targets was run on this branch and passed:
What this does not cover
The sixteen carried rows were not re-derived. Their readings were taken in 0010
against the same two commits, that record keeps its text, and this change carries
the rows without retaking the evidence behind them. The record says so in its own
words rather than leaving a reader to assume otherwise. What was retaken is the two
line tips and everything about the route being added.
No implementation. Nothing in this change makes a request, and nothing in the
tree does. The core reaches no network at all today, which is why the row is
decided rather than discovered.
The parameter is not fixed.
enableResumabledefaults to a set that overlapsthe resume list, which the record states as a cost of the route; what a call asks
for is #39's, and choosing the value here would decide one issue inside another.
Nothing here is a statement about a running server. Every line was read out of
the server's source at two commits. The comparison against a real server is #104.
0039 is untouched. Its own reversal condition names this case and says what is
owed when it fires - a statement of what next up is in terms of the page and the
item - and the new record supplies it. Whether 0039 should also carry a pointer to
it is that record's question and a change to a file this one does not open.
No check reads any of this. There is no check over
docs/decisions/, sonothing refuses a record whose index line is missing or whose supersession is
spelled wrong. The
Documents name paths that resolvecheck reads link targets andcode spans and is what stands behind the resolution above, and it reads neither a
Statusline nor an index.Who has read it
Nobody other than the author has read this change.