Skip to content

Admit the per-line tag segment in the requests source pattern - #161

Open
iderex wants to merge 1 commit into
mainfrom
line-tags-requests
Open

Admit the per-line tag segment in the requests source pattern#161
iderex wants to merge 1 commit into
mainfrom
line-tags-requests

Conversation

@iderex

@iderex iderex commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Half of what Flowfin/jellyfin-plugin-requests#110 waits on, the half that is a file in this tree: sources/requests.json selects only the bare version convention today, so a release tagged under the one-version-many-lines decision (1.2.3.4-jf12-stable) would be published and never reach the manifest.

The pattern gains an optional per-line segment, probed both ways:

python -c "
import re
neu = r'^v?[0-9]+\.[0-9]+\.[0-9]+(\.[0-9]+)?(-jf[0-9]+)?(-stable)?$'
ok  = ['1.2.3','v1.2.3.4','1.2.3.4-stable','1.2.3.4-jf12-stable','1.2.3.4-jf13-stable','1.2.3.4-jf12']
bad = ['1.2.3-beta','1.2.3.4-jf12-beta','1.2-stable','1.2.3.4-stable-jf12','beta-1.2.3']
assert all(re.match(neu,t) for t in ok) and not any(re.match(neu,t) for t in bad); print('ok')
"
ok

The note in the file now names the line segment and where it came from. The channel still hangs on the tag convention, and the catalogue still separates lines by targetAbi - the segment only names which line a file came from. The second half of #110, shipping the first 12.0-line release, is the operator's tagging act and stays on that issue.

A release tagged 1.2.3.4-jf12-stable under the one-version-many-lines
decision (Flowfin/jellyfin-plugin-requests#110) matches no pattern here
today, so it would be published and never reach the manifest. The pattern
gains an optional (-jf[0-9]+) segment between the version and -stable; the
channel still hangs on the tag convention and the catalogue still separates
lines by targetAbi. Probed: 1.2.3, v1.2.3.4, 1.2.3.4-stable,
1.2.3.4-jf12-stable and 1.2.3.4-jf12 match; 1.2.3-beta, 1.2.3.4-jf12-beta,
1.2-stable and 1.2.3.4-stable-jf12 do not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant