Admit the per-line tag segment in the requests source pattern - #161
Open
iderex wants to merge 1 commit into
Open
Admit the per-line tag segment in the requests source pattern#161iderex wants to merge 1 commit into
iderex wants to merge 1 commit into
Conversation
A release tagged 1.2.3.4-jf12-stable under the one-version-many-lines decision (Flowfin/jellyfin-plugin-requests#110) matches no pattern here today, so it would be published and never reach the manifest. The pattern gains an optional (-jf[0-9]+) segment between the version and -stable; the channel still hangs on the tag convention and the catalogue still separates lines by targetAbi. Probed: 1.2.3, v1.2.3.4, 1.2.3.4-stable, 1.2.3.4-jf12-stable and 1.2.3.4-jf12 match; 1.2.3-beta, 1.2.3.4-jf12-beta, 1.2-stable and 1.2.3.4-stable-jf12 do not.
iderex
enabled auto-merge
August 30, 2026 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Half of what Flowfin/jellyfin-plugin-requests#110 waits on, the half that is a file in this tree: sources/requests.json selects only the bare version convention today, so a release tagged under the one-version-many-lines decision (1.2.3.4-jf12-stable) would be published and never reach the manifest.
The pattern gains an optional per-line segment, probed both ways:
The note in the file now names the line segment and where it came from. The channel still hangs on the tag convention, and the catalogue still separates lines by targetAbi - the segment only names which line a file came from. The second half of #110, shipping the first 12.0-line release, is the operator's tagging act and stays on that issue.