Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/promotion.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ names which corners those were while the reason is still remembered.
## What promotion does not create

It is not a promise of support from this board. Nothing here is maintained
against anybody else's use of it, and an experiment does not gain a maintainer
by being taken somewhere.
against anybody else's use of it, and an experiment does not gain anybody who
will keep it working by being taken somewhere.

It is not a claim that the code is finished. The line above about what would
have to change is the measure of that, and it is part of the hand-over rather
Expand Down
2 changes: 1 addition & 1 deletion docs/quality-parity.md
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ below is the one that was absent either way.
| Parameter | Here | Target | Verdict |
| --- | --- | --- | --- |
| `allowed_merge_methods` | `["merge","squash","rebase"]` | `["merge"]` | Change owed. This is the one deviation in this walk worth closing rather than reasoning away, and the reason is below. |
| `required_approving_review_count` | `0` | `0` | Kept. A count above zero on a board with one maintainer refuses every merge, and a rule nobody can satisfy is switched off in a hurry rather than met. |
| `required_approving_review_count` | `0` | `0` | Kept. A count above zero on a board where I am the only reviewer refuses every merge, and a rule nobody can satisfy is switched off in a hurry rather than met. |
| `dismiss_stale_reviews_on_push` | `false` | `false` | Kept. It only bites where a review is required, and none is required at a count of zero. |
| `require_last_push_approval` | `false` | `false` | Kept, for the reason in the row above. |
| `required_review_thread_resolution` | `false` | `false` | Kept, for the reason two rows above. |
Expand Down
8 changes: 4 additions & 4 deletions internal/invariants/invariants.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ const (
)

// DeclaredLicence is the licence this repository has decided on. Record 0018
// answers entry one of the maintainer question issue with GPL-3.0, one licence
// for the runner and the experiment content alike, and issue #47 is the change
// that lands the file and sets this string.
// answers entry one of issue #46 with GPL-3.0, one licence for the runner and
// the experiment content alike, and issue #47 is the change that lands the file
// and sets this string.
//
// IT IS SPELLED AS THE TITLE LINE RATHER THAN AS THE SPDX IDENTIFIER, and that
// is forced by what the leg below asks. The leg asks whether the licence file
Expand Down Expand Up @@ -368,7 +368,7 @@ func licenceLeg(root, declaredLicence string) (Leg, []Refusal) {
return Leg{
Name: "the licence",
NotAsked: fmt.Sprintf("no licence is declared, so there is nothing to compare %s against. "+
"asking costs answering entry one of the maintainer question issue and landing the file, "+
"asking costs answering entry one of issue #46 and landing the file, "+
"the repository metadata and the decision record that names it, which is issue #47", LicenceName),
}, nil
}
Expand Down
Loading