Skip to content

fix: handle null activeElement in _spaceCatcher AND fix: guard _moveManual and _ariaChecked against dom-repeat race AND MORE#51

Merged
paodb merged 6 commits into
masterfrom
fix-49-50
May 7, 2026
Merged

fix: handle null activeElement in _spaceCatcher AND fix: guard _moveManual and _ariaChecked against dom-repeat race AND MORE#51
paodb merged 6 commits into
masterfrom
fix-49-50

Conversation

@javier-godoy
Copy link
Copy Markdown
Member

@javier-godoy javier-godoy commented May 6, 2026

Close #49
Close #50

Summary by CodeRabbit

  • Bug Fixes

    • Dot navigation now follows the actually rendered dots to prevent off-by-one and out-of-bounds navigation.
    • Click handling consolidated to a single delegated listener and cleaned up on detach to avoid duplicate handlers or leaks.
    • Dot-related styles are only initialized when dots exist.
  • Accessibility

    • Dot controls expose accurate aria-checked states and per-dot aria-labels.
    • Keyboard/focus detection for advancing slides improved.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

moveManual causes undefined setAttribute spaceCatcher causes null-access

2 participants