Conversation
WalkthroughThe PR adds per-export tooltip support to GridExporter, allowing users to configure tooltip text and behavior for Excel, DOCX, PDF, and CSV export buttons. Public setter methods enable customization before grid attachment, applied via a shared helper during grid setup. The version bumps to 3.1.0-SNAPSHOT. ChangesExport Tooltip Configuration Feature
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java`:
- Around line 236-247: applyExportTooltip currently creates a Tooltip whenever a
configurator is provided, which prevents honoring null as "disable tooltip";
change applyExportTooltip so that if text is null it does not create or modify a
Tooltip even when a configurator is non-null — i.e., short-circuit before
calling Tooltip.forComponent(component) when text == null (unless you intend
null to only disable default text, in which case update docs instead); locate
applyExportTooltip, remove or bypass the Tooltip.forComponent(...) and
configurator.accept(...) calls when text is null, ensuring tooltip.setText(text)
and configurator.accept(tooltip) only run on a non-null text (or adjust docs if
you prefer the other behavior).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5af98e59-8e2b-4be8-9b9a-dea50ef4bce8
📒 Files selected for processing (3)
pom.xmlsrc/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.javasrc/test/java/com/flowingcode/vaadin/addons/gridexporter/GridExporterDemo.java
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |



Close #114.
Export to Excel/Word/PDF/CSV) to the four auto-attached export icons rendered byGridExporter.createFor.set*ExportTooltipText(String)for simple overrides. Passnullto opt out of a specific tooltip entirely.set*ExportTooltipConfigurator(SerializableConsumer<Tooltip>)for advanced customization (position, opening delay, etc.); receives the live VaadinTooltipinstance at attach time.GridExporterDemoto showcase both the text override (Excel) and the configurator (CSV →TooltipPosition.TOP).Summary by CodeRabbit
New Features
Chores