chore(security): patch 1 Dependabot alert#1578
Closed
PMerlet wants to merge 1 commit into
Closed
Conversation
- Bump fast-xml-parser to >=5.7.0 via Yarn resolution to address GHSA-gh4j-gqv2-49f6 (XML Comment/CDATA Injection in XMLBuilder). Pulled transitively via @aws-sdk/xml-builder in plugin-aws-s3. - Remove 6 redundant root resolutions (axios, follow-redirects, hono, @hono/node-server, langsmith, lodash-es) whose natural resolutions now satisfy the original pin.
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
1 fixed, 6 ignored, 6 deferred, 1 resolution added, 6 resolutions removed. | label: 🔒 security applied
Fixed
**/fast-xml-parser: ">=5.7.0"(transitive via@aws-sdk/client-s3 → @aws-sdk/core → @aws-sdk/xml-builder); xml-builder pinsfast-xml-parserexactly so a parent bump alone wouldn't close the alertIgnored
packages/agentdevDependencies(and as an optional peer dep). Fixed version 4.0.5 requiresexpress ^5.2.1andfastify-plugin ^5.0.0(i.e. fastify v5). We ship support for fastify v2/v3/v4. The auth bypass requires a real HTTP server with untrusted input; our test suite drives only controlled requests.@fastify/expresspeer/dev install atpackages/agent).@nestjs/platform-fastify@10.x, which is indevDependenciesofpackages/agentandpackages/_example;@nestjs/platform-fastify@10.4.16exact-pins@fastify/middie@8.3.3. Patched version 9.3.2 requiresfastify-plugin@5/@fastify/error@4(fastify v5 ecosystem). Tests do not expose untrusted HTTP input.Deferred
Skipped by the 7-day age gate (will be picked up next run): #344, #345, #346, #347, #348 (all uuid, 2 days old), #349 (ip-address, 0 days).
Resolutions added
>=5.7.0— placed at rootpackage.jsonunderresolutions, unconditional**/form.@aws-sdk/client-s3(^3.750.0→ latest 3.1044.0) would not deterministically close the alert because xml-builder pinsfast-xml-parserto an exact version — only the latest xml-builder builds use 5.7.x. A parent bump is therefore non-deterministic; a resolution is required.resolutionsaren't honored by Yarn 1)."@aws-sdk/xml-builder/fast-xml-parser": ">=5.7.0"was tried first and did not override the xml-builder request (Yarn 1 oddity with scoped-package paths). Fell back to the**/form, which only matches one chain in this repo so the blast radius is narrow.Resolutions removed
Audited every entry in root
resolutionsby temporarily removing it, runningyarn install, and checking whether the natural resolution still satisfied the original pin. Removed when redundant (parent packages now pull a satisfying version on their own).package.jsonaxios: ^1.15.01.15.2package.jsonfollow-redirects: ^1.16.01.16.0package.jsonhono: ^4.12.124.12.14package.json@hono/node-server: ^1.19.131.19.14package.jsonlangsmith: ^0.5.180.5.21package.jsonlodash-es: ^4.18.04.18.1Pins kept (still needed):
tar,lerna/**/glob,micromatch,semantic-release,qs,lodash. Removingsemantic-releasetriggered a Yarn 1Invariant Violationduring install regardless of resolved version, so the pin was kept on stability grounds rather than vulnerability grounds.Risks
strnum/@nodable/entities/path-expression-matcherruntime deps and tightens the XML escaping rules used by the builder (the patched code path). The parser API surface used by@aws-sdk/xml-builderfor response parsing in@aws-sdk/client-s3is unchanged. No expected behavior change beyond the patched vuln.Manual testing
Covered by CI.
Validation
✅ CI green