Skip to content

Handle duplicate legacy point backfills - #3227

Open
Freika wants to merge 1 commit into
devfrom
fix/legacy-lonlat-duplicates
Open

Handle duplicate legacy point backfills#3227
Freika wants to merge 1 commit into
devfrom
fix/legacy-lonlat-duplicates

Conversation

@Freika

@Freika Freika commented Jul 25, 2026

Copy link
Copy Markdown
Owner

GitHub issue: #3200

Summary

  • removes exact legacy-only point duplicates before backfilling lonlat
  • walks the large points table once in ID-ordered batches
  • keeps affected user and import point counters accurate
  • covers duplicate and normal backfill paths across batch boundaries

Verification

  • focused regression: 1 example, 0 failures
  • RuboCop: 2 files, no offenses
  • full RSpec: 7,016 examples, 1 pre-existing failure in google_phone_takeout_invalid_utf8_spec.rb
  • the same unrelated failure reproduces on OneDev dev at 1ec08149d20a83f10d0c1936f6028f48d36182e3

Review

  • cycle 1 findings fixed: large-table cursor batching, import counter maintenance, release-note scope

Coordination

GitHub PR #3198 changes the same migration for an adjacent lock-timeout crash and will require merge-order coordination; it does not handle this duplicate-key failure.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d4acc6c4-eb4f-45db-b768-304b489f4dad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/legacy-lonlat-duplicates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant