Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Release 3.6.0 focuses on hardening and consolidating the addon’s tracking write-path and reducing redundant aggregation queries by introducing a shared in-memory repository for pagestats_data type aggregations.
Changes:
- Refactors tracking writes in
Visit(and parts ofEventRequest) from manual string SQL to parameterized upsert helpers, including a bulk upsert path forpagestats_data. - Introduces
DataTypeAggregationRepositoryto load and cache multiplepagestats_dataaggregation types via a single query, reused by the variouslib/data/*classes. - Replaces direct
$_SERVERusage for specific headers/client hints with REDAXO server access (rex_server) and a dedicated client-hints server bag builder.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/Visit.php | Consolidates counter upserts into helper(s), adds bulk upsert for pagestats_data, and replaces certain $_SERVER reads with rex_server/client-hints bag. |
| lib/DataTypeAggregationRepository.php | New static repository that loads multiple pagestats_data types in one query and caches per request. |
| lib/data/Weekday.php | Switches weekday aggregation loading to the shared repository. |
| lib/data/OS.php | Switches OS aggregation loading to the shared repository. |
| lib/data/Model.php | Switches model aggregation loading to the shared repository. |
| lib/data/Hour.php | Switches hour aggregation loading to the shared repository. |
| lib/data/Country.php | Switches country aggregation loading to the shared repository. |
| lib/data/Browsertype.php | Switches browsertype aggregation loading to the shared repository. |
| lib/data/Browser.php | Switches browser aggregation loading to the shared repository. |
| lib/data/Brand.php | Switches brand aggregation loading to the shared repository. |
| lib/api/EventRequest.php | Consolidates hash “touch” into an upsert helper and switches client-hints input away from raw $_SERVER. |
| Changelog.md | Extends 3.6.0 notes to include the SQL hardening, aggregation consolidation, and REDAXO $_SERVER hardening items. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[3.6.0] - 07.08.2026
exceljs.min.jsundjspdf.umd.min.jsentfernt sowie die nicht mehr benötigten Composer-Abhängigkeitenphpoffice/phpspreadsheetundmatomo/referrer-spam-blacklistaus dem Addon entfernt.toolsund.githubwerden überinstaller_ignoresowie per.gitattributes(export-ignore) aus Release-Archiven ausgeschlossen.github/workflows/update-frontend-assets.yml)addslashesinVisitauf parametrisierte Upsert-Queries umgestellt, wiederholte Counter-Upserts inVisit/EventRequestüber interne Helper konsolidiert und denpagestats_data-Write-Path per Bulk-Upsert reduziert$_SERVER-Zugriffe inVisit/EventRequestdurch REDAXO-Serverzugriff ersetzt (u. a. Client-Hints undHTTP_VIA)psalm.xmlentfernt und README um eine Maintainer-Sektion für.toolserweitert