fix: frozen UI state after login/logout#52
Open
olivereisenhut wants to merge 1 commit intomasterfrom
Open
Conversation
Until now, we closed the window after a login or logout and opened a fresh one via `runCommand(context)`. `sketch-module-web-view` no longer destroys (no idea when this changed) the webview on `win.close()`. This means trying to open a new window via `win.close()` will give an error as it reuses the existing window. This left the UI stuck in the current view, even though the logout/login was successful. Instead of re-running the main function again, we just load the new view into the existing webview after the login/logout finished.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, we closed the window after a login or logout and opened a
fresh one via
runCommand(context).sketch-module-web-viewno longer destroys (no idea when this changed)the webview on
win.close().This means trying to open a new window via
win.close()will give anerror as it reuses the existing window.
This left the UI stuck in the current view, even though the logout/login
was successful.
Instead of re-running the main function again, we just load the new view into
the existing webview after the login/logout finished.