Fixing some bugs leftover from updates to data load/extraction#37
Open
DTMilodowski wants to merge 1 commit into
Open
Fixing some bugs leftover from updates to data load/extraction#37DTMilodowski wants to merge 1 commit into
DTMilodowski wants to merge 1 commit into
Conversation
Contributor
|
Hi David,
I think this must be the result of Github's attempted merge. I don't have the place_obs_in_step variable code sections still present.
Thanks,
Luke
From: David Milodowski ***@***.***>
Sent: 02 March 2026 15:28
To: GCEL/CARDAMOM ***@***.***>
Cc: Luke Smallman ***@***.***>; Review requested ***@***.***>
Subject: [GCEL/CARDAMOM] Fixing some bugs leftover from updates to data load/extraction (PR #37)
I think this is a wee bug in loading in the wood dynamics datasets from gridded datasets. Searching for a variable: "place_obs_in_step" which is now not created. The check has been replaced as part of the harmonization by reference to a variable "data_available", but these three items appear to be left with the old way of doing things
…________________________________
You can view, comment on, or merge this pull request online at:
#37
Commit Summary
* 74fd1bb<74fd1bb> Fixing some bugs leftover from updates to data load/extraction
File Changes
(1 file<https://github.com/GCEL/CARDAMOM/pull/37/files>)
* M R_functions/extract_obs.r<https://github.com/GCEL/CARDAMOM/pull/37/files#diff-8bd61fb5652a79e57e76685790921b8a641e0f862dfdbed50e01b13698d748c4> (6)
Patch Links:
* https://github.com/GCEL/CARDAMOM/pull/37.patch
* https://github.com/GCEL/CARDAMOM/pull/37.diff
-
Reply to this email directly, view it on GitHub<#37>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGDTODJBCYLEW5YBB42BXMD4OWR6TAVCNFSM6AAAAACWELKMVWVHI2DSMVQWIX3LMV43ASLTON2WKOZUGAYTCOBVGEYTOOI>.
You are receiving this because your review was requested.Message ID: ***@***.******@***.***>>
The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th' ann an Oilthigh Dh?n ?ideann, cl?raichte an Alba, ?ireamh cl?raidh SC005336.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a wee bug in loading in the wood dynamics datasets from gridded datasets. Searching for a variable: "place_obs_in_step" which is now not created. The check has been replaced as part of the harmonization by reference to a variable "data_available", but these three items appear to be left with the old way of doing things