fix(web-ui): restore inline ACP file approval actions#588
Merged
GCWing merged 1 commit intoGCWing:mainfrom May 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR restores inline ACP approval controls for file operation tool cards in FlowChat.
Specifically, it updates
FileOperationToolCardso ACP-triggered confirmation states forWrite,Edit, andDeleterender as compact header actions on the right side of the card, instead of leaving the session waiting without an obvious approval entry point.Why
ACP file permission requests were reaching the frontend and correctly marking the tool card as
pending_confirmation, but file operation cards did not expose confirm/reject controls in that state.As a result, ACP-backed sessions could get stuck waiting for approval while the UI only showed the tool card and a waiting state, with no visible way for the user to continue.
User impact
Users can now approve or reject ACP file operations directly from the file operation tool card header.
This makes ACP file confirmations behave consistently with other compact approval surfaces in FlowChat and avoids the "stuck waiting for permission with no visible action" failure mode.
Root cause
Write,Edit, andDeletetool calls are rendered throughFileOperationToolCard, but that card did not implement the same inline approval affordance used by other tool cards.The ACP permission event path was already working, but the file card UI was missing the last-mile interaction layer.
Implementation notes
onConfirmandonRejectintoFileOperationToolCardrequiresConfirmationanduserConfirmedDeletecardsValidation
pnpm run lint:webpnpm run type-check:webpnpm --dir src/web-ui run test:run