cleanup of FPE#338
Open
rrsettgast wants to merge 10 commits into
Open
Conversation
Contributor
|
rocmcc supports the cuda flag: https://rocm.docs.amd.com/en/docs-6.0.2/reference/rocmcc.html |
Contributor
|
misclick |
Expose system::queryEnabledFloatingPointExceptions() so callers can verify which FE_* exceptions are actually trap-enabled after changing the floating-point environment. Implement platform-specific handling for glibc, Apple arm64 FPCR, and Apple x86 fenv control words, allowing trapless FPUs to be detected when enable calls appear to succeed. Extend FPE tests to cover the query helper and disable optimization for FPE helper operations across all builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to cleanup our treatment of FPE and underflow flushing. Goals: