Skip to content

Cache enum .values() #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boubou19 merged 1 commit into from
Aug 10, 2026
+3 −1
Merged

Cache enum .values() #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/com/glodblock/github/common/storage/CellType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ public enum CellType {
Cell4096kPart(6, AEFeature.StorageCells),
Cell16384kPart(7, AEFeature.StorageCells);

public static final CellType[] VALUES = values();

private final EnumSet<AEFeature> features;
private int damageValue;
private Item itemInstance;
Expand Down Expand Up @@ -53,7 +55,7 @@ public void setItemInstance(final Item itemInstance) {
}

public static EnumChatFormatting getTypeColor(int type) {
return getTypeColor(CellType.values()[type % CellType.values().length]);
return getTypeColor(CellType.VALUES[type % CellType.VALUES.length]);
}

public static EnumChatFormatting getTypeColor(CellType type) {
Expand Down