fix(action): normalize packaged chart metadata#182
Merged
Conversation
Normalize root and nested Chart.yaml payloads to LF before archive creation so HelmSharp packages match Helm byte-for-byte across platforms. Expand golden coverage to compare complete archive payloads while preserving source files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Chart.yamlpayloads to LF before writing chart archivesWhy
On Windows, source CRLF metadata was preserved in HelmSharp archives while Helm emits LF, causing byte-level archive entry mismatches across net8.0, net9.0, and net10.0.
Verification
dotnet test tests/HelmSharp.Tests/HelmSharp.Tests.csproj --configuration Release --filter FullyQualifiedName~PackageMetadataValidationTests(net8/9/10: 28/28 each)dotnet test HelmSharp.sln --configuration Release --no-build --no-restore(net8/9/10: 520/520 each)dotnet pack HelmSharp.sln --configuration Release --no-build --output artifacts/packages-local(9 packages + symbols)Fixes #180