fix(dependencies): close review parity gaps#189
Conversation
Align dependency list, recursive global values, vendored dependencies, duplicate alias staging, and exact repository/file lock builds with Helm behavior. Add Helm CLI golden coverage for each follow-up and preserve the existing public API surface.
|
@codex review |
1 similar comment
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21857ce330
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21857ce330
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep valid packaged archives for repository-less local dependencies during update and build cleanup while continuing to remove non-local stale archives. Cover both phases against the Helm CLI oracle.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
What changed
dependency liststatus with Helm v4 by using declared constraints and ignoring condition/tag enablementChart.lockversions for repository andfile://sources[Unreleased]Why
Historical Codex review threads on PRs #171, #172, #176, and #177 identified parity gaps that remained after those PRs merged. This follow-up closes the reproducible gaps and records already-fixed duplicate staging behavior.
Verification
dotnet test HelmSharp.sln --configuration Release— 544/544 on net8.0, net9.0, and net10.0dotnet pack HelmSharp.sln --configuration Release --no-build --output artifacts/packages-local— 9 nupkg and 9 snupkggit diff --checkFixes #185