bugfix(audio): Prevent race condition when accessing deleted drawables from audio thread#461
Open
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
Open
bugfix(audio): Prevent race condition when accessing deleted drawables from audio thread#461seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
Conversation
…s from audio thread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CLIENT-4BM. The issue was that: Audio thread accesses freed Drawable memory via
findDrawableByIDdue to a race condition with main thread's object destruction.m_drawableLookupMutex, inGameClientto guard drawable lookup access and drawable lifetime.GameClientconstructor and closed it in the destructor.GameClient::removeDrawableto acquire them_drawableLookupMutexbefore removing a drawable from the lookup table and freeing its memory, preventing concurrent access by other threads.AudioEventRTS::getPositionto acquire them_drawableLookupMutexwhen looking up a drawable by ID and retrieving its position, ensuring the drawable is not deleted mid-operation by the main thread.Common/ScopedMutex.hin relevant files to facilitate mutex usage.This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13189844
Not quite right? Click here to continue debugging with Seer.