Skip to content

bugfix(textureloader): Add null checks for D3DTexture to prevent crashes#479

Open
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer/bugfix/texture-null-checks
Open

bugfix(textureloader): Add null checks for D3DTexture to prevent crashes#479
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer/bugfix/texture-null-checks

Conversation

@seer-by-sentry
Copy link
Copy Markdown

Fixes CLIENT-4F0. The issue was that: Texture creation failure in Begin_Compressed_Load/Begin_Uncompressed_Load not propagated, causing Lock_Surfaces to dereference a null D3DTexture.

  • Added null checks for D3DTexture after loading attempts in Load_D3D_Texture_From_Memory and Load_D3D_Texture_From_File.
  • Added a null check for D3DTexture before surface locking in Lock_Surfaces.
  • Prevents potential crashes or undefined behavior if D3DTexture creation or loading fails.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13755203

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants