Skip to content

bugfix: Fix game freezing on transition and disconnecting when alt tabbed on game start#480

Open
MrS-ibra wants to merge 1 commit intoGeneralsOnlineDevelopmentTeam:mainfrom
MrS-ibra:bugfix/fullscreen-alt-tab-disconnect
Open

bugfix: Fix game freezing on transition and disconnecting when alt tabbed on game start#480
MrS-ibra wants to merge 1 commit intoGeneralsOnlineDevelopmentTeam:mainfrom
MrS-ibra:bugfix/fullscreen-alt-tab-disconnect

Conversation

@MrS-ibra
Copy link
Copy Markdown
Member

When a player alt tabs out on exclusive fullscreen while in lobby and the host starts the game, the main loop sleeps and never resumes. The existing break condition only checks isInMultiplayerGame() which returns false until the game simulation has started. This means MSG_NEW_GAME is never processed for us when the host starts the game while we are tabbed out, leaving the player frozen on the loading screen and appearing disconnected to other players.

The fix checks TheNetwork in the break condition, which is created the moment the host starts the game, allowing the sleep loop to break out and MSG_NEW_GAME to be processed

This also prevents an ELO exploit in quickmatch where a player could deliberately alt tab during matchmaking to appear disconnected, forcing other players into the disconnect screen and gaining ELO points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant