Room selection enhancements#17
Open
fallouh wants to merge 2 commits intoGeneralsOnlineDevelopmentTeam:mainfrom
Open
Room selection enhancements#17fallouh wants to merge 2 commits intoGeneralsOnlineDevelopmentTeam:mainfrom
fallouh wants to merge 2 commits intoGeneralsOnlineDevelopmentTeam:mainfrom
Conversation
- Automatically add lobby to multiple rooms when applicable
…change as needed. We need a bit more code consistency.
Author
|
We should also change this in the client side to fetch from the Backend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greeting!
As a player, I find it always confusing having the top-right room selection not showing the things actually existing in the "ALL GAMES" section.
I've created this PR to address this issue by allowing a lobby to exist in multiple room and assiging the rooms automatically based on the description "lobby title".
I believe this will enhance the User experience to meet the expectations of the filter and makes it more useful.
I just discovered the project source code today despite being a player for generals online for a while. I could not finish the setup of the DB so I could not test it, but I made sure the project builds and I believe the changes are non-breaking and backward compatible.
It would be awesome to give it a quick test.
Cheers.