Feat: Abstract Mascot Rendering and move team Abbreviations to Sanity#238
Open
josh-torre wants to merge 2 commits into
Open
Feat: Abstract Mascot Rendering and move team Abbreviations to Sanity#238josh-torre wants to merge 2 commits into
josh-torre wants to merge 2 commits into
Conversation
Contributor
👷 Deploy Preview for sprightly-manatee-243873 processing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did I do?
Abstracted the rendering of the "characters" under the "Choose Your Character" section to pull their color from the Sanity team schema. With this, it ensures that the shadow under each character is consistent across all characters and allows for easier changes to colors in the future.
Team abbreviations for each team that are rendered on the arcade machine are now pulled from the sanity schema rather than hard coded. This allows for team names to be easily changed and makes added new teams easier.
How did I test it?
I compared the results for the new changes rendered the same as the existing website.
Required checks:
What could go wrong in the future? What parts of your code should the reviewer pay the most attention to?
The only thing that could come up is a difference between the names of teams and the team name that is listed under the director information. If a different spelling is used for the director's team than there will be no color/abbreviation for them
Additional Comments for the Reviewers
Screenshots
FIGMA
MY VERSION