feat(admin-ui): implement responsive mobile layout for the Security m…#2927
feat(admin-ui): implement responsive mobile layout for the Security m…#2927faisalsiddique4400 wants to merge 3 commits into
Conversation
…odule (#2925) Signed-off-by: faisalsiddique4400 <faisalsiddique10886@gmail.com>
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mo-auto
added
comp-admin-ui
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@admin-ui/.husky/pre-commit`:
- Around line 12-18: Update the pre-commit signing check around GPGSIGN and
SIGNINGKEY so it enforces only commit.gpgsign being enabled, without requiring
user.signingkey to be set. Remove the SIGNINGKEY lookup and related
condition/message, while preserving the existing failure guidance for unsigned
commits.
In `@admin-ui/.husky/pre-push`:
- Around line 39-40: Update the printf call in the pre-push hook to use a fixed
%b format string when outputting UNSIGNED, and remove the SC2059 suppression.
Preserve expansion of the embedded newline escapes while ensuring percent
characters in commit subjects are printed literally.
In `@admin-ui/app/routes/Dashboards/DashboardPage.style.ts`:
- Around line 437-440: Update the selector in the compact-width styles to target
only the heading rather than every first-of-type child. Replace “& >
:first-of-type” with “& > :first-child” or the existing explicit heading class,
while preserving the current flexBasis and marginBottom values.
In `@admin-ui/plugins/admin/components/Cedarling/CedarlingConfigPage.tsx`:
- Around line 294-340: Preserve Cedarling policy-store actions on mobile by
removing isMobile from GluuUploadFile.disabled and from the conditions
controlling the download and upload footer actions in CedarlingConfigPage.tsx;
retain permission and loading-state checks. In
admin-ui/plugins/admin/components/Cedarling/CedarlingConfigPage.style.ts lines
149-159, remove the viewport-only not-allowed cursor styling so the cursor
reflects the actual disabled state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: ce96cfe3-8791-416a-9a45-2dbfacf0e0d2
📒 Files selected for processing (40)
admin-ui/.husky/commit-msgadmin-ui/.husky/pre-commitadmin-ui/.husky/pre-pushadmin-ui/app/components/GluuDropdown/GluuDropdown.tsxadmin-ui/app/constants/ui.tsadmin-ui/app/locales/en/translation.jsonadmin-ui/app/locales/es/translation.jsonadmin-ui/app/locales/fr/translation.jsonadmin-ui/app/locales/pt/translation.jsonadmin-ui/app/routes/Apps/Gluu/GluuSelectRow.tsxadmin-ui/app/routes/Apps/Gluu/styles/GluuInputRow.style.tsadmin-ui/app/routes/Apps/Gluu/styles/GluuSelectRow.style.tsadmin-ui/app/routes/Apps/Gluu/types/common.tsadmin-ui/app/routes/Dashboards/DashboardPage.style.tsadmin-ui/app/routes/License/LicenseDetailsPage.style.tsadmin-ui/app/styles/fonts.tsadmin-ui/app/styles/formStyles.tsadmin-ui/app/styles/mobileDisabledFieldStyles.tsadmin-ui/app/utils/types/TokenControllerTypes.tsadmin-ui/plugins/admin/components/Cedarling/CedarlingConfigPage.style.tsadmin-ui/plugins/admin/components/Cedarling/CedarlingConfigPage.tsxadmin-ui/plugins/admin/components/Health/HealthPage.style.tsadmin-ui/plugins/admin/components/MAU/MauPage.style.tsadmin-ui/plugins/admin/components/Mapping/RolePermissionCard.tsxadmin-ui/plugins/admin/components/Mapping/RolePermissionMappingPage.tsxadmin-ui/plugins/admin/components/Mapping/__tests__/RolePermissionCard.test.tsxadmin-ui/plugins/admin/components/Mapping/styles/MappingPage.style.tsadmin-ui/plugins/admin/components/Settings/SettingsPage.style.tsadmin-ui/plugins/admin/helper/assets.tsadmin-ui/plugins/admin/helper/webhook.tsadmin-ui/plugins/auth-server/components/AuthServerProperties/types/index.tsadmin-ui/plugins/auth-server/components/ConfigApiProperties/utils/valueUtils.tsadmin-ui/plugins/auth-server/components/Sessions/types/sessionTypes.tsadmin-ui/plugins/saml/components/WebsiteSsoServiceProviderForm.tsxadmin-ui/plugins/saml/helper/utils.tsadmin-ui/plugins/saml/types/formValues.tsadmin-ui/plugins/scim/components/ScimPage.tsxadmin-ui/plugins/user-claims/components/types/UserClaimsListPage.types.tsadmin-ui/plugins/user-management/components/UserDetailViewPage.tsxadmin-ui/vite.config.ts
Signed-off-by: faisalsiddique4400 <faisalsiddique10886@gmail.com>
Signed-off-by: faisalsiddique4400 <faisalsiddique10886@gmail.com>
|
duttarnab
left a comment
duttarnab
left a comment
There was a problem hiding this comment.
I think we should removed this screen in mobile view as the mobile view only supports write only operation. What is your opinion?
3 participants
feat(admin-ui): implement responsive mobile layout for the Security module (#2925)
Summary
This PR extends the Admin UI mobile redesign by implementing a responsive layout for the Security module.
The update optimizes the Security module for mobile devices by adapting layouts, spacing, and responsive behavior to smaller viewports while preserving the existing desktop and tablet experience. The implementation follows the shared mobile design patterns introduced across the Admin UI.
Fix Summary
Verification
passes successfully.
🔗 Ticket
Closes: #2925
Summary by CodeRabbit