chore(deps): update dependency mocha to v12 - #420
Open
renovate-bot wants to merge 1 commit into
Open
Conversation
Collaborator
|
/gcbrun |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request upgrades the Mocha test runner from version 11.7.5 to 12.0.0 across several example projects, along with updating their lockfiles. However, upgrading to Mocha v12 drops support for Node.js versions older than 20.19.0, which will break test execution on Node 18 in the multiple-node-versions-example project.
| "devDependencies": { | ||
| "chai": "6.2.2", | ||
| "mocha": "11.7.5", | ||
| "mocha": "12.0.0", |
Contributor
There was a problem hiding this comment.
Upgrading to Mocha v12 drops support for Node.js < 20.19.0 (including Node 18). This will break test execution on Node 18, which is likely tested in this multiple-node-versions-example project. If Node 18 support is still required, Mocha should be kept at v11.
Suggested change
| "mocha": "12.0.0", | |
| "mocha": "11.7.5", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
11.7.5→12.0.0Release Notes
mochajs/mocha (mocha)
v12.0.0Compare Source
🩹 Fixes
📚 Documentation
🧹 Chores
v11.8.0Compare Source
v11.7.6Compare Source
🩹 Fixes
describe().timeout()work (aafe6fd)wmicusage with native Windows API (#5694) (73ebdfa)🧹 Chores
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.