Skip to content

Feat petverse multimodal skills - #1523

Open
Lsubatin wants to merge 3 commits into
mainfrom
feat-petverse-multimodal-skills
Open

Feat petverse multimodal skills#1523
Lsubatin wants to merge 3 commits into
mainfrom
feat-petverse-multimodal-skills

Conversation

@Lsubatin

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the companion files for the "PetVerse: Analyze Multimodal Data with BigQuery and AI" Google Skills lab, including setup scripts, environment configuration, and application prompt guidelines. The review feedback highlights a critical issue in petverse-setup.sh where an invalid --condition=None flag is used with gcloud projects add-iam-policy-binding, which would cause silent failures. Additionally, it suggests using standard tools like grep and cut instead of jq for better compatibility, and improving the environment loading logic in setenv.sh to ensure local .env configurations correctly override global ones.

Comment thread codelabs/petverse-multimodal-skills/petverse-setup.sh Outdated
Comment thread codelabs/petverse-multimodal-skills/petverse-setup.sh
Comment thread codelabs/petverse-multimodal-skills/setenv.sh
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant