feat(app-dev): add zero-trust secure shopping cart with Firebase Auth, Firestore Rules & Cloud Run - #1536
Merged
Merged
Conversation
…, Firestore Rules & Cloud Run
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a secure serverless shopping cart application demonstrating Firebase Authentication, path-based Firestore security rules, and a server-authoritative Cloud Run backend. The feedback identifies three main improvement opportunities: resolving a race condition in server.js where clearUserCart resolves before asynchronous deletions complete, preventing potential socket leaks by resuming the patchRes stream, and optimizing cart migration in index.html by parallelizing sequential Firestore document reads using Promise.all.
…ze cart migration reads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.