docs(toolbox): fix the kcagent CLI name and the demo_ecommerce cleanup target#121
Open
mftnakrsu wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot I signed it! |
mftnakrsu
force-pushed
the
docs/fix-enrichment-doc-references
branch
from
26dab61 to
64ef7cf
Compare
…p target The enrichment README's CLI prose named `kcenrich` while every example uses `kcagent`; align the prose with the actual tool name. The cleanup step also dropped `:demo-dataset`, but the walkthrough creates the `demo_ecommerce` schema, so the command removed nothing — point it at the schema that is actually created.
mftnakrsu
force-pushed
the
docs/fix-enrichment-doc-references
branch
from
64ef7cf to
ea655d2
Compare
mftnakrsu
changed the title
Author
|
@amirhormati a small |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduced after rebasing onto
main.The original PR also corrected doc paths and a CLI-name reference under
agents/enrichment/**, but that folder was removed upstream in #128, sothose four changes are now obsolete and have been dropped. What remains is
the still-valid
toolbox/enrichment/README.mdfix:kcenrichtool, while every example in theREADME invokes
kcagent— aligned the prose with the actual tool name.bq rm -r …:demo-dataset, but the walkthroughcreates the
demo_ecommerceschema, so the command removed nothing —pointed it at the schema that is actually created.
🤖 Generated with Claude Code