Skip to content

tracing: remove explicit schema URL when building tracer provider resource (release-2.53.5-gmp) - #349

Merged
bwplotka merged 1 commit into
release-2.53.5-gmpfrom
bwplotka/tracing-remove-schema-url-2.53
Aug 4, 2026
Merged

tracing: remove explicit schema URL when building tracer provider resource (release-2.53.5-gmp)#349
bwplotka merged 1 commit into
release-2.53.5-gmpfrom
bwplotka/tracing-remove-schema-url-2.53

Conversation

@bwplotka

@bwplotka bwplotka commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Remove explicit schema URL when building tracer provider resource in tracing/tracing.go to avoid schema URL mismatch errors when resources are merged.

Rationale -- we don't need to have extra upgrade step: GoogleCloudPlatform/prometheus-engine#2015 (comment)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the resource.WithSchemaURL(semconv.SchemaURL) option from the OpenTelemetry resource creation in tracing/tracing.go. I have no feedback to provide as there are no review comments.

@bwplotka

bwplotka commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

Hm, can I really remove if we have explicit svcNames?

resource.WithAttributes(

Consulted with @dashpole - should be fine as this is the source of conflict.

@bwplotka
bwplotka merged commit a1320e2 into release-2.53.5-gmp Aug 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants