chore(Storage Control) Relocate storage control sample#14094
chore(Storage Control) Relocate storage control sample#14094XrossFox wants to merge 8 commits intoGoogleCloudPlatform:mainfrom
Conversation
… storagecontrol/. - Fixed bad indent. - Tested script.
There was a problem hiding this comment.
Code Review
This pull request updates the documentation regarding GCS folder behavior and modifies the delete_empty_folders.py script. Key feedback includes a critical bug in the should_retry function where integer status codes are incorrectly compared to gRPC enums, which would prevent retries from functioning. Additionally, the reviewer suggests increasing the MAX_WORKERS count for better performance and moving the retry_policy instantiation to the module level to improve efficiency by avoiding redundant object creation.
|
generally, you have to do these in 2 phases. 1 create the new location, update documentation, delete old, or freeze the sample where it's being pulled in documentation, move, and then unfreeze. Are you doing either of those processes here? |
Hello, i forgot and skipped a step by pre-emptively deleting the source. Will restore files, then once merged, edit doc (https://docs.cloud.google.com/storage/docs/hns-buckets-best-practices.md) and then finally delete old code again. |
Relocate Storage Control sample to delete nested HNS Folders.
Fixes # b/503111470 #14090
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)