Refactor/fix archetecture mistakes - #31
Merged
Merged
Conversation
- Aggregate each feature's sub-routers behind a single package-level router (coding, interview, platform, question_voice, speech, theory) and mount them uniformly in app/main.py - Refactor SpeechRuntimeCoordinator to delegate STT/TTS loading to dedicated backend abstractions (SttModelLoader, TtsEngine) under app/speech/domain - Update gateways, transcriber resolver, tests, and docs accordingly
- Move the add-model flow (form validation, connection probe, catalog persistence, error handling) out of the config router into AddLLMModelUseCase under app/platform/use_cases - Wire the use case through DI (AddLLMModelUseCaseDep) with the config and catalog services injected as dependencies - Slim down the add_llm_model handler to transport and rendering only - Fix dead mocks in config tests that patched LLMCatalogService via app.platform.api.config instead of the real app.platform.queries.config_form
…equired in probe Pass NewLLMModel as a whole into AddLLMModelUseCase.execute instead of threading individual form fields, and fail the catalog probe early when a model requires an API key but none was provided.
Narrow request.app.state.speech_runtime via isinstance so the dependency returns SpeechRuntimeCoordinator instead of Any.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Changes Made
Testing
uv run pytest)Checklist
uv run ruff check,uv run ruff format,uv run mypy)Related Issues
Fixes #
Screenshots (if applicable)
Additional Notes