Skip to content

Refactored lab1 to pull out tutorial related content into respective tutorial pages - #83

Open
SadhviNarayanan wants to merge 2 commits into
mainfrom
lab1_refactor
Open

Refactored lab1 to pull out tutorial related content into respective tutorial pages#83
SadhviNarayanan wants to merge 2 commits into
mainfrom
lab1_refactor

Conversation

@SadhviNarayanan

Copy link
Copy Markdown

Refactored lab1 to pull out tutorial related content into respective tutorial pages, kept lab1 specific information within the lab 1, and marked in the tutorials when to go back to lab1.
Done by Sadhvi + Julia.

…ive tutorial pages, and kept lab1 specific information within the lab 1, and marked in the tutorials when to go back to lab1
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

⚡ Cloudflare Pages preview

Your changes are live for review:

Preview URL https://f0e0c1fd.hmc-e155.pages.dev
Branch alias https://lab1-refactor.hmc-e155.pages.dev
Commit 212e5f76f57c127ea0bbf1baa4e13eebb75a9b48

Updated automatically on each push to this PR.

@mespence

mespence commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Great work thus far! Notes:

  • Make sure all discussions of RTL hierarchy are consistent with specs. Notably, describing the module they must make as having a clock port is kind of deceptive because the HSOSC module provides the clock at the top level.
  • Spoiler the example testbench and make sure the module name is lab1_led_controller_tb (and the module is lab1_led_controller). Arguably testbench design could be moved into a tutorial, though it would require new writing (main points: test benches must cover all functionality of module, combinational benches exercise every input combination, sequential testbenches nominally need to exercise every state transition but that can be a lot for counters, top testbenches only test stuff not covered by module tests)
  • In pin assignment - modify the appropriate sentence to read "not being used for other purposes by checking the schematic" and link the schematic.
  • List some part numbers in the 7 segment section. Referring to the "side" of the 7 segment will be weird for folks who wind up with a single display rather than a dual display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants