refactor(effects-manager): extract GLSL shaders to .glsl files via raw-loader (#886)#933
Closed
deveshbervar wants to merge 1 commit into
Closed
refactor(effects-manager): extract GLSL shaders to .glsl files via raw-loader (#886)#933deveshbervar wants to merge 1 commit into
deveshbervar wants to merge 1 commit into
Conversation
deveshbervar
force-pushed
the
refactor/shader-extraction-886
branch
from
0db2a82 to
4f18a1c
Compare
sponce
reviewed
Jun 17, 2026
Comment on lines
+20
to
+30
| const VERTEX_SHADER = ` | ||
| uniform float opacity; | ||
| uniform float colorR; | ||
| uniform float colorG; | ||
| uniform float colorB; | ||
|
|
||
| void main() { | ||
| gl_Position = projectionMatrix * modelViewMatrix * vec4(position, 1.0); | ||
| } | ||
| `; | ||
|
|
Collaborator
There was a problem hiding this comment.
I'm not really sure I'm qualified to comment on this MR, as I have actually no clue how shaders work.
So be indulgent if my question is stupid, but I'm just a bit surprised that the "extraction of GLSL shaders' as the title says only results is having the shader code duplicated in 2 places, this one and the new nice glsl file. Is there no way to have it only in the glsl file ? What if the 2 are not in sync ?
deveshbervar
force-pushed
the
refactor/shader-extraction-886
branch
2 times, most recently
from
36d8bd1 to
d395667
Compare
…w-loader (HSF#886) style: format glsl declaration file fix: vertex shader uniforms, glsl.d.ts format, phoenix-ng jest glsl mock fix: copy glsl shaders to dist after tsc build fix: inline shader code to avoid glsl loader dependency fix: inline shader code to avoid glsl loader dependency
deveshbervar
force-pushed
the
refactor/shader-extraction-886
branch
from
d395667 to
6393b72
Compare
Collaborator
Author
|
Hi @sponce, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 (PR 2a of 2) of the refactoring proposed in #886.
Extracts the two inline GLSL shader strings from
effects-manager.tsinto dedicated.glslfiles,loaded at build time via
raw-loader.What changed
New files:
shaders/hover-vertex.glsl— vertex shader extracted from TS stringshaders/hover-fragment.glsl— fragment shader extracted from TS stringsrc/glsl.d.ts— TypeScript declaration for.glslimportssrc/tests/helpers/glsl-mock.js— Jest mock for.glslfilesModified files:
configs/webpack.conf.js— addedraw-loaderrule for.glslconfigs/jest.conf.js— addedmoduleNameMapperfor.glslin testseffects-manager.ts— replaced inline strings with ES6 importspackage.json— addedraw-loaderas devDependencyWhy
From #886 Gap 1: GLSL embedded as TypeScript strings has no validation path — a syntax error only surfaces at WebGL
runtime, never in
yarn test:ci.This extraction is the prerequisite for PR 2b which adds
glslangValidatorCI validation.Scope