Mohammed A#5
Open
mohammedalfakih-dev wants to merge 1 commit into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
📝 HackYourFuture auto gradeAssignment Score: 87 / 100 ✅Status: ✅ Passed Test Details |
AgneseGi
reviewed
Jun 10, 2026
AgneseGi
left a comment
There was a problem hiding this comment.
very solid work! the only minor issues were:
- missing the required outlier decision/comment
- hiding AI_ASSIST.md content inside HTML comments
- catching broad Azure exceptions as “container already exists”
| ## The prompt I gave | ||
|
|
||
| <!-- Paste the exact prompt you gave the LLM here. --> | ||
| <!-- How do I convert a Pandas column to datetime and replace invalid dates with missing values? --> |
There was a problem hiding this comment.
content is inside HTML comments, so it is effectively invisible when rendered
|
|
||
| logging.info("Cleaned sales rows: %s", len(sales)) | ||
|
|
||
| return sales |
There was a problem hiding this comment.
this does not include the required outlier decision - you could have added a comment or decide to remove them using eg .quantile(0.99)
| container.create_container() | ||
| logging.info("Created container %s", container_name) | ||
| except Exception: | ||
| logging.info("Container %s already exists", container_name) |
There was a problem hiding this comment.
Here any error is treated as “container already exists":this might hide real failures like eg ClientAuthenticationError
you could use instead
except ResourceExistsError:
logging.info("Container %s already exists", container_name)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completed the Week 4 Pandas pipeline assignment.
Changes