Mohamad Bader AA by noneeeed · Pull Request #12 · HackYourAssignment/c55-data-week-5

noneeeed · 2026-06-03T17:15:00Z

No description provided.

…y, and may belong to a fork outside of the repository. removing to readd

github-actions · 2026-06-03T17:16:17Z

✅ Image pushed to ACR

hyfregistry.azurecr.io/noneeeed-pipeline:5fd44445b109c70624544195887bf8c8998cec52

Browse the registry in the Azure Portal: https://portal.azure.com/#@hackyourfuture.nl/resource/subscriptions/1120c89d-2a5f-4a15-a582-2ea34f0bb5c3/resourceGroups/rg-hyf-data/providers/Microsoft.ContainerRegistry/registries/hyfregistry/repository

Task 7 verification: your Dockerfile built and pushed cleanly from commit 5fd4444.

Resolves conflict in .github/workflows/ci.yml header by keeping the explanatory note from main. Also adds the if-guard to Azure/ACR steps so CI stays green on fork PRs (the central Grade ACR push workflow on main does the actual push).

github-actions · 2026-06-03T20:02:22Z

✅ Image pushed to ACR

hyfregistry.azurecr.io/noneeeed-pipeline:dd75307f56eaed404afc8687233337254859a0ed

Browse the registry in the Azure Portal: https://portal.azure.com/#@hackyourfuture.nl/resource/subscriptions/1120c89d-2a5f-4a15-a582-2ea34f0bb5c3/resourceGroups/rg-hyf-data/providers/Microsoft.ContainerRegistry/registries/hyfregistry/repository

Task 7 verification: your Dockerfile built and pushed cleanly from commit dd75307.

…nto week5-attempt

github-actions · 2026-06-10T11:32:34Z

📝 HackYourFuture auto grade

Assignment Score: 93 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 60
🧪 The auto grade is experimental and still being improved

Test Details


=== Week 5 Autograder ===
  PASS: Level 1: required files (15/15 pts)
  PASS: Dockerfile uses python:3.11-slim base image
  PASS: Dockerfile copies requirements before source (cache-friendly)
  PASS: Dockerfile has a CMD instruction
  PASS: Level 2: Dockerfile (15/15 pts)
  PASS: tests/test_pipeline.py has 13 test functions (≥2 required)
  PASS: tests/test_pipeline.py has no NotImplementedError stubs remaining
  PASS: Level 3: unit tests (10/10 pts)
  PASS: requirements.txt has 9 pinned package(s)
  PASS: requirements.txt pins satisfied (no uv.lock needed)
  PASS: Level 4: pinned dependencies (10/10 pts)
  PASS: ci.yml triggers on pull_request
  PASS: ci.yml triggers on push to main
  PASS: ci.yml runs ruff check (lint)
  PASS: ci.yml runs ruff format (format check)
  PASS: ci.yml runs pytest
  PASS: ci.yml runs docker build
  PASS: Level 5: CI workflow (20/20 pts)
  PASS: pipeline.py reads config from os.environ/os.getenv
  FAIL: pipeline.py still contains NotImplementedError
  PASS: Level 6: env-var config (10/15 pts)
  PASS: assets/acr_push_week5.png present and non-trivial (95444 bytes)
  PASS: Level 7: ACR screenshot (10/10 pts)
  PASS: AI_ASSIST.md has all three required sections
  FAIL: AI_ASSIST.md still contains TODO placeholders or is too short (19812 chars)
  PASS: Level 8: AI report (3/5 pts)
  PASS: .gitignore correctly excludes __pycache__/, *.pyc, and .env

Score: 93 / 100  (passing: 60)  pass=true

github-actions · 2026-06-10T11:33:47Z

✅ Image pushed to ACR

hyfregistry.azurecr.io/noneeeed-pipeline:c2ebea78a0835abd83a49d1ef966402a0e294366

Browse the registry in the Azure Portal: https://portal.azure.com/#@hackyourfuture.nl/resource/subscriptions/1120c89d-2a5f-4a15-a582-2ea34f0bb5c3/resourceGroups/rg-hyf-data/providers/Microsoft.ContainerRegistry/registries/hyfregistry/repository

Task 7 verification: your Dockerfile built and pushed cleanly from commit c2ebea7.

qiraahmad · 2026-06-17T23:04:22Z

AI_ASSIST is supposed to look like a structured reflection, not a log dump.

Add your actual question(s) to the LLM, in your words
e.g. "How do I pass Azure credentials into a Docker container for DefaultAzureCredential?"

The code or suggestion it returned (you can summarise it)

What was changed after reviewing it and document what you tried, what worked, what didn't, what you still don't understand

qiraahmad · 2026-06-17T23:05:09Z

+COPY requirements.txt .
+RUN pip install -r requirements.txt
+COPY src/ ./src/
+RUN curl -sL https://aka.ms/InstallAzureCLIDeb | bash


Line 6 runs curl before curl is installed. python:3.11-slim doesn't include curl, and curl comes with line 7–8 via apt-get.

Fix the order:

RUN apt-get update && apt-get install -y curl ca-certificates && rm -rf /var/lib/apt/lists/*

Then install Azure CLI once

RUN pip install --no-cache-dir -r requirements.txt

Always verify locally:
docker build -t test .
docker run --rm -e API_KEY=test -e GITHUB_USERNAME=noneeeed test

qiraahmad · 2026-06-17T23:06:32Z

-CMD ["TODO"]
+COPY requirements.txt .
+RUN pip install -r requirements.txt
+COPY src/ ./src/


The image only copies src/, not data/.

Your run() calls download_inputs(DATA_DIR) which needs either:

AZURE_STORAGE_CONNECTION_STRING

COPY data/ ./data/ if you bundle local CSVs for offline runs

Right now docker run will fail at the download step unless you pass secrets. Document which approach you chose in AI_ASSIST.md and the PR description.

qiraahmad · 2026-06-17T23:07:07Z

+    logger.info("Script finished.")
+
+
+def upload_outputs(output_dir: Path, github_username: str) -> None:


can be removed if not implemented

qiraahmad · 2026-06-17T23:09:23Z

+    logger.info("Initializing Azure credentials...")
+    # credential = DefaultAzureCredential()
+    # service = BlobServiceClient(account_url=ACCOUNT_URL, credential=credential)
+    conn = os.environ.get("AZURE_STORAGE_CONNECTION_STRING")


If AZURE_STORAGE_CONNECTION_STRING is missing, raise a clear RuntimeError

noneeeed added 16 commits June 3, 2026 13:26

added project from week4

0686fb3

added pipeline from older project with added functions

d295d69

added env example

f56d70a

added report.py from older project

c43eb81

added requirements

4a04433

added 3 extra tests

38a7e5e

added dockerfile and dockerignore

2787e12

added ci, edited requirements

543db59

updated missing handles

dd94bed

removed azure-cli from requirements

1800890

added Ai assist

15f4a49

fixed ruff error

8a027c8

fixed missing test var github_username

6107061

added week5-acr-png

26aacaf

got error This commit does not belong to any branch on this repositor…

348c4ac

…y, and may belong to a fork outside of the repository. removing to readd

readded png

5fd4444

This comment has been minimized.

Sign in to view

Merge main + skip Azure/ACR steps on fork PRs

dd75307

Resolves conflict in .github/workflows/ci.yml header by keeping the explanatory note from main. Also adds the if-guard to Azure/ACR steps so CI stays green on fork PRs (the central Grade ACR push workflow on main does the actual push).

This comment has been minimized.

Sign in to view

noneeeed added 2 commits June 10, 2026 13:32

updated few mistakes

dda3bf5

Merge branch 'week5-attempt' of github.com:noneeeed/c55-data-week-5 i…

c2ebea7

…nto week5-attempt

qiraahmad reviewed Jun 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mohamad Bader AA#12

Mohamad Bader AA#12
noneeeed wants to merge 19 commits into
HackYourAssignment:mainfrom
noneeeed:week5-attempt

noneeeed commented Jun 3, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Jun 3, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

qiraahmad Jun 17, 2026

Uh oh!

qiraahmad Jun 17, 2026

Uh oh!

qiraahmad Jun 17, 2026

Uh oh!

qiraahmad Jun 17, 2026

Uh oh!

qiraahmad Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		logger.info("Script finished.")


		def upload_outputs(output_dir: Path, github_username: str) -> None:

Conversation

noneeeed commented Jun 3, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Jun 3, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

📝 HackYourFuture auto grade

Assignment Score: 93 / 100 ✅

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

qiraahmad Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

qiraahmad Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

qiraahmad Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

qiraahmad Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

qiraahmad Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants