Skip to content

Pavel Tisner#14

Open
pavel-tisner wants to merge 3 commits into
HackYourAssignment:mainfrom
pavel-tisner:week5-attempt
Open

Pavel Tisner#14
pavel-tisner wants to merge 3 commits into
HackYourAssignment:mainfrom
pavel-tisner:week5-attempt

Conversation

@pavel-tisner

Copy link
Copy Markdown
  • Containerized my Week 3 API ingestion pipeline
  • Added pinned dependencies
  • Added unit tests
  • Added CI with ruff, format check, pytest, and Docker build
  • Pushed the image to Azure Container Registry using the fallback laptop path
  • Added the ACR screenshot to assets/acr_push_week5.png
  • Filled in AI_ASSIST.md

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

📝 HackYourFuture auto grade

Assignment Score: 100 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 60
🧪 The auto grade is experimental and still being improved

Test Details

=== Week 5 Autograder ===
  PASS: Level 1: required files (15/15 pts)
  PASS: Dockerfile uses python:3.11-slim base image
  PASS: Dockerfile copies requirements before source (cache-friendly)
  PASS: Dockerfile has a CMD instruction
  PASS: Level 2: Dockerfile (15/15 pts)
  PASS: tests/test_pipeline.py has 5 test functions (≥2 required)
  PASS: tests/test_pipeline.py has no NotImplementedError stubs remaining
  PASS: Level 3: unit tests (10/10 pts)
  PASS: requirements.txt has 4 pinned package(s)
  PASS: requirements.txt pins satisfied (no uv.lock needed)
  PASS: Level 4: pinned dependencies (10/10 pts)
  PASS: ci.yml triggers on pull_request
  PASS: ci.yml triggers on push to main
  PASS: ci.yml runs ruff check (lint)
  PASS: ci.yml runs ruff format (format check)
  PASS: ci.yml runs pytest
  PASS: ci.yml runs docker build
  PASS: Level 5: CI workflow (20/20 pts)
  PASS: pipeline.py reads config from os.environ/os.getenv
  PASS: pipeline.py has no NotImplementedError stubs remaining
  PASS: Level 6: env-var config (15/15 pts)
  PASS: assets/acr_push_week5.png present and non-trivial (195367 bytes)
  PASS: Level 7: ACR screenshot (10/10 pts)
  PASS: AI_ASSIST.md has all three required sections
  PASS: AI_ASSIST.md is filled in (2783 chars, no TODO placeholders)
  PASS: Level 8: AI report (5/5 pts)
  PASS: .gitignore correctly excludes __pycache__/, *.pyc, and .env

Score: 100 / 100  (passing: 60)  pass=true

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Image pushed to ACR

hyfregistry.azurecr.io/pavel-tisner-pipeline:1b870317a2f65c423861c921c5ab145fbfcdb152

Browse the registry in the Azure Portal: https://portal.azure.com/#@hackyourfuture.nl/resource/subscriptions/1120c89d-2a5f-4a15-a582-2ea34f0bb5c3/resourceGroups/rg-hyf-data/providers/Microsoft.ContainerRegistry/registries/hyfregistry/repository

Task 7 verification: your Dockerfile built and pushed cleanly from commit 1b87031.

@AgneseGi AgneseGi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great complete work!

Comment thread Dockerfile

# TODO: copy source code
COPY src/ src/
COPY data/ data/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the image depend on local bundled data. That is okay for a demo, but for a shippable pipeline it is often better to pass input paths or mount data at runtime, so the image stays reusable across environments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants