Skip to content

Halyna R.#6

Open
halyna1995 wants to merge 5 commits into
HackYourAssignment:mainfrom
halyna1995:week5/halyna
Open

Halyna R.#6
halyna1995 wants to merge 5 commits into
HackYourAssignment:mainfrom
halyna1995:week5/halyna

Conversation

@halyna1995

@halyna1995 halyna1995 commented Jun 2, 2026

Copy link
Copy Markdown

Complete week 5 container assignment

halyna1995 added 2 commits June 2, 2026 21:45
@halyna1995
Merge pull request #1 from HackYourAssignment/main
4c836d4 
Sync from HackYourAssignment/c55-data-week-5 (Grade workflow fix)
@halyna1995
Complete week 5 container assignment
d1f3d14
@github-actions

This comment has been minimized.

Sign in to view
ci: skip Azure/ACR steps on fork PRs
d97eb9e 
GitHub withholds AZURE_CREDENTIALS from pull_request runs that originate
from a fork, causing the azure/login step to fail. The if-guard skips the
Azure/ACR steps on fork PRs so CI stays green. The central Grade ACR push
workflow on the assignment repo's main handles the actual push from
base-repo context (where the secret is available) and comments the image
URL on the PR.
@github-actions

This comment has been minimized.

Sign in to view
@lassebenni lassebenni closed this Jun 3, 2026
@lassebenni lassebenni reopened this Jun 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

✅ Image pushed to ACR

hyfregistry.azurecr.io/halyna1995-pipeline:d97eb9e3d47f4aed3b98b0a7f9030db51cb4b446

Browse the registry in the Azure Portal: https://portal.azure.com/#@hackyourfuture.nl/resource/subscriptions/1120c89d-2a5f-4a15-a582-2ea34f0bb5c3/resourceGroups/rg-hyf-data/providers/Microsoft.ContainerRegistry/registries/hyfregistry/repository

Task 7 verification: your Dockerfile built and pushed cleanly from commit d97eb9e.

@HackYourAssignment HackYourAssignment deleted a comment from github-actions Bot Jun 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

✅ Image pushed to ACR

hyfregistry.azurecr.io/halyna1995-pipeline:e2d101d10e1dc5e8c751ef4e5560401f38443a97

Browse the registry in the Azure Portal: https://portal.azure.com/#@hackyourfuture.nl/resource/subscriptions/1120c89d-2a5f-4a15-a582-2ea34f0bb5c3/resourceGroups/rg-hyf-data/providers/Microsoft.ContainerRegistry/registries/hyfregistry/repository

Task 7 verification: your Dockerfile built and pushed cleanly from commit e2d101d.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

📝 HackYourFuture auto grade

Assignment Score: 95 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 60
🧪 The auto grade is experimental and still being improved

Test Details 

=== Week 5 Autograder ===
  PASS: Level 1: required files (15/15 pts)
  PASS: Dockerfile uses python:3.11-slim base image
  PASS: Dockerfile copies requirements before source (cache-friendly)
  PASS: Dockerfile has a CMD instruction
  PASS: Level 2: Dockerfile (15/15 pts)
  PASS: tests/test_pipeline.py has 10 test functions (≥2 required)
  PASS: tests/test_pipeline.py has no NotImplementedError stubs remaining
  PASS: Level 3: unit tests (10/10 pts)
  PASS: requirements.txt has 2 pinned package(s)
  PASS: requirements.txt pins satisfied (no uv.lock needed)
  PASS: Level 4: pinned dependencies (10/10 pts)
  PASS: ci.yml triggers on pull_request
  PASS: ci.yml triggers on push to main
  PASS: ci.yml runs ruff check (lint)
  PASS: ci.yml runs ruff format (format check)
  PASS: ci.yml runs pytest
  PASS: ci.yml runs docker build
  PASS: Level 5: CI workflow (20/20 pts)
  PASS: pipeline.py reads config from os.environ/os.getenv
  FAIL: pipeline.py still contains NotImplementedError
  PASS: Level 6: env-var config (10/15 pts)
  PASS: assets/acr_push_week5.png present and non-trivial (117644 bytes)
  PASS: Level 7: ACR screenshot (10/10 pts)
  PASS: AI_ASSIST.md has all three required sections
  PASS: AI_ASSIST.md is filled in (1401 chars, no TODO placeholders)
  PASS: Level 8: AI report (5/5 pts)
  PASS: .gitignore correctly excludes __pycache__/, *.pyc, and .env

Score: 95 / 100  (passing: 60)  pass=true

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

✅ Image pushed to ACR

hyfregistry.azurecr.io/halyna1995-pipeline:a760dce87a53d9f14e40ad72171b755e8046763b

Browse the registry in the Azure Portal: https://portal.azure.com/#@hackyourfuture.nl/resource/subscriptions/1120c89d-2a5f-4a15-a582-2ea34f0bb5c3/resourceGroups/rg-hyf-data/providers/Microsoft.ContainerRegistry/registries/hyfregistry/repository

Task 7 verification: your Dockerfile built and pushed cleanly from commit a760dce.

AgneseGi
AgneseGi reviewed Jun 12, 2026
View reviewed changes

@AgneseGi AgneseGi left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core implementation is good, but the PR is not shippable due to failed CI test

Comment thread tests/test_pipeline.py
assert results_file.exists()

def test_file_contains_records(self, tmp_path):
"""Test that save_results() writes the correct number of records to results.txt."""

@AgneseGi AgneseGi Jun 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is causing CI to fail with E501 because it is longer than 88 characters. Wrap the docstring onto multiple lines or shorten it so ruff check src tests passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AgneseGi AgneseGi AgneseGi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@halyna1995 @AgneseGi @lassebenni