Skip to content

Mareh A.#6

Open
mareh-aboghanem wants to merge 1 commit into
HackYourAssignment:mainfrom
mareh-aboghanem:week6/mareh
Open

Mareh A.#6
mareh-aboghanem wants to merge 1 commit into
HackYourAssignment:mainfrom
mareh-aboghanem:week6/mareh

Conversation

@mareh-aboghanem

Copy link
Copy Markdown

The logic behind this week's assignment was easy to follow, but typing out all the different commands felt a bit unfamiliar. I think I need a little more practice to get completely familiar with the CLI workflow!

@mareh-aboghanem mareh-aboghanem changed the title Finish week 6 assignment Mareh A. Jun 10, 2026
@lassebenni lassebenni closed this Jun 10, 2026
@lassebenni lassebenni reopened this Jun 10, 2026
@github-actions

Copy link
Copy Markdown

📝 HackYourFuture auto grade

Assignment Score: 100 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 60
🧪 The auto grade is experimental and still being improved

Test Details

=== Week 6 Autograder ===
  ✓ PASS  found Dockerfile
  ✓ PASS  found requirements.txt
  ✓ PASS  found src/pipeline.py
  ✓ PASS  found AI_ASSIST.md
  ✓ PASS  found README.md
  ✓ PASS  found docs/ directory
  ✓ PASS  Level 1: required files (10/10 pts)
  ✓ PASS  requirements.txt pins azure-storage-blob
  ✓ PASS  requirements.txt pins psycopg2-binary
  ✓ PASS  Level 2: pinned dependencies (10/10 pts)
  ✓ PASS  Dockerfile uses a python:3.11 base image
  ✓ PASS  Dockerfile copies requirements before src/ (layer cache stays warm)
  ✓ PASS  Dockerfile has a real CMD instruction
  ✓ PASS  Level 3: Dockerfile (10/10 pts)
  ✓ PASS  pipeline.py reads POSTGRES_URL and AZURE_STORAGE_CONNECTION_STRING from env
  ✓ PASS  pipeline.py uses contextlib.closing() to wrap the Postgres connection
  ✓ PASS  pipeline.py silences the azure SDK logger
  ✓ PASS  Level 4: pipeline shape (15/15 pts)
  ✓ PASS  pipeline.py uses an upsert (ON CONFLICT ... DO UPDATE)
  ✓ PASS  pipeline.py uses %s placeholders in execute() (parameterised SQL)
  ✓ PASS  Level 5: idempotent upsert (15/15 pts)
  ✓ PASS  connection string includes sslmode=require
  ✓ PASS  pipeline.py uses the azure-storage-blob SDK (BlobServiceClient)
  ✓ PASS  Level 6: connection + SDK (10/10 pts)
  ✓ PASS  AI_ASSIST.md has all three sections and is filled in (3176 chars)
  ✓ PASS  Level 7: AI report (10/10 pts)
  ✓ PASS  README.md has '## Verification' heading and embeds a docs/ image
  ✓ PASS  Level 8: README verification (10/10 pts)
  ✓ PASS  execution-history screenshot present at execution_history.png (14083 bytes)
  ✓ PASS  Level 9: execution screenshot (10/10 pts)
  ✓ PASS  .gitignore correctly excludes __pycache__/, *.pyc, and .env

Score: 100 / 100  (passing: 60)  pass=true

Comment thread src/pipeline.py
)
conn_postgres=os.environ.get("POSTGRES_URL")
if not conn_postgres:
logging.info(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to use logger.error(...) or print(..., file=sys.stderr), to display errors

Comment thread src/pipeline.py
Comment on lines +97 to +99
blob_name = f"raw/{source}/{date.today().isoformat()}.json"
json_data = json.dumps(records)
container_client.upload_blob(blob_name, data=json_data, overwrite=True)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path is not being built correctly, raw is being added multiple times

@qiraahmad

Copy link
Copy Markdown

Great job on this submission, I liked how thoughtful your AI_ASSIST was. Only added a few minor changes needed. 4/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants