Mareh A.#6
Open
mareh-aboghanem wants to merge 1 commit into
Open
Conversation
📝 HackYourFuture auto gradeAssignment Score: 100 / 100 ✅Status: ✅ Passed Test Details |
qiraahmad
reviewed
Jun 17, 2026
| ) | ||
| conn_postgres=os.environ.get("POSTGRES_URL") | ||
| if not conn_postgres: | ||
| logging.info( |
There was a problem hiding this comment.
I would suggest to use logger.error(...) or print(..., file=sys.stderr), to display errors
qiraahmad
reviewed
Jun 17, 2026
Comment on lines
+97
to
+99
| blob_name = f"raw/{source}/{date.today().isoformat()}.json" | ||
| json_data = json.dumps(records) | ||
| container_client.upload_blob(blob_name, data=json_data, overwrite=True) |
There was a problem hiding this comment.
The path is not being built correctly, raw is being added multiple times
|
Great job on this submission, I liked how thoughtful your AI_ASSIST was. Only added a few minor changes needed. 4/5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic behind this week's assignment was easy to follow, but typing out all the different commands felt a bit unfamiliar. I think I need a little more practice to get completely familiar with the CLI workflow!