feat: Threat Generation Support#21
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| private static (int Exit, string Stdout) Capture(Func<int> run) | ||
| { | ||
| StringWriter outWriter = new StringWriter(); |
| private static (int Exit, string Stdout) Capture(Func<int> run) | ||
| { | ||
| StringWriter outWriter = new StringWriter(); | ||
| StringWriter errorWriter = new StringWriter(); |
Comment on lines
+157
to
+164
| foreach (string candidate in assembly.GetManifestResourceNames()) | ||
| { | ||
| if (candidate.EndsWith(suffix, StringComparison.Ordinal)) | ||
| { | ||
| resource = candidate; | ||
| break; | ||
| } | ||
| } |
Comment on lines
+304
to
+310
| foreach (Threat threat in model.AllThreatsDictionary.Values) | ||
| { | ||
| if (threat.Id > max) | ||
| { | ||
| max = threat.Id; | ||
| } | ||
| } |
Comment on lines
+130
to
+137
| foreach (object property in surface.Properties) | ||
| { | ||
| if (property is StringDisplayAttribute named && | ||
| string.Equals(named.DisplayName, "Name", StringComparison.Ordinal)) | ||
| { | ||
| return; | ||
| } | ||
| } |
Comment on lines
+456
to
+463
| foreach (ThreatStateDto state in dto.Threats ?? Array.Empty<ThreatStateDto>()) | ||
| { | ||
| if (!string.IsNullOrEmpty(state.Id) && | ||
| string.Equals(state.State, "Accepted", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| ThreatGenerator.Accept(model, state.Id, state.Justification ?? string.Empty); | ||
| } | ||
| } |
| public void Initialize() | ||
| { | ||
| this.WorkingDirectory = Path.Combine(Path.GetTempPath(), "tmforge-lint-" + Guid.NewGuid().ToString("N")); | ||
| this.WorkingDirectory = Path.Combine(Path.GetTempPath(), "tmforge-analyze-" + Guid.NewGuid().ToString("N")); |
| private string WorkingDirectory { get; set; } = string.Empty; | ||
|
|
||
| /// <summary>Gets the path of the model created by <see cref="NewModelWithFlow"/>.</summary> | ||
| private string ModelPath => Path.Combine(this.WorkingDirectory, "model.tm7"); |
| [TestInitialize] | ||
| public void Initialize() | ||
| { | ||
| this.WorkingDirectory = Path.Combine(Path.GetTempPath(), "tmforge-threats-" + Guid.NewGuid().ToString("N")); |
Comment on lines
+138
to
+144
| foreach (JsonElement threat in data.GetProperty("threats").EnumerateArray()) | ||
| { | ||
| if (threat.GetProperty("ruleId").GetString() == ruleId) | ||
| { | ||
| return true; | ||
| } | ||
| } |
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is absolutely massive, but includes the following highlights.