Fix untranslated strings and restore translators-comment checks - #102
Open
miyanialkesh7 wants to merge 1 commit into
Open
Fix untranslated strings and restore translators-comment checks#102miyanialkesh7 wants to merge 1 commit into
miyanialkesh7 wants to merge 1 commit into
Conversation
Member
|
@miyanialkesh7 LGTM! Could you just undo the version bump and leave it as a comment instead? I’ll merge all the changes when I’m preparing the next release. |
- Wrap 3 hardcoded strings (placeholder/aria-label attributes) in the SMS, Spam Protection, and Tools tabs with esc_attr_e(). - Remove the file-wide "phpcs:disable WordPress.WP.I18n.MissingTranslatorsComment" from 7 files. It was silently exempting any future printf()/sprintf() placeholder string in these files from ever needing a translators comment. Restoring the check immediately surfaced one real gap in login.php, where the comment sat above printf() instead of directly above the __() call the sniff checks against; fixed by moving it down. Verified all other calls in these 7 files still pass with 0 new errors.
miyanialkesh7
force-pushed
the
fix/i18n-untranslated-strings
branch
from
August 25, 2026 06:07
8a4f45c to
c8b4036
Compare
Author
|
@mustafauysal Removed the version bump and changelog entry from this PR as well (force-pushed the amended commit). It now only contains the i18n/translators-comment fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esc_attr_e()— SMS, Spam Protection, and Tools tabs.// phpcs:disable WordPress.WP.I18n.MissingTranslatorsCommentfrom 7 files that was silently exempting any future placeholder string in those files from ever needing a translators comment.printf()instead of directly above the__()call the sniff checks against. Fixed by moving it down one line.Test Plan
php -lon all 9 changed files — no syntax errorsvendor/bin/phpcs --standard=phpcs.xmlon all 7 affected files — 0 errors/warnings after the fix (was 1 warning before)vendor/bin/phpunit— 8/8 passingwp plugin check magic-login— 0 translator-related findings