Improves Player Display and Refactors Campaign View#341
Open
Lakeyzer wants to merge 2 commits into
Open
Conversation
Previously, passive skill and save DC columns were incorrectly hidden if `userSettings.general` was `undefined` or `null`. The updated logic ensures these columns are displayed by default, only hiding if explicitly configured otherwise within the user's general settings.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhances player column visibility by improving null checks for user general settings, preventing display issues when settings are unconfigured.
Refactors the Campaign Overview component, updating the player display component and integrating character synchronization data when an extension is installed.